Skip to content

Rely on the SessionObserver to detect a sign out.#6182

Merged
bmarty merged 1 commit intodevelopfrom
feature/bma/fixAppNavigationState
Feb 11, 2026
Merged

Rely on the SessionObserver to detect a sign out.#6182
bmarty merged 1 commit intodevelopfrom
feature/bma/fixAppNavigationState

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Feb 11, 2026

Content

Rely on the SessionObserver to detect a sign out.

Motivation and context

Relying on the navigation state was not working since the owner of the state is not the same.

Screenshots / GIFs

Tests

  • Sign in to account 1
  • Sign in to account 2
  • Let account 2 get some notification displayed
  • Sign out from account 2

Observe that the notification for account 2 are correctly dismissed. It was not the case with the previous code.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner February 11, 2026 17:21
@bmarty bmarty requested review from ganfra and removed request for a team February 11, 2026 17:21
@bmarty bmarty added the PR-Bugfix For bug fix label Feb 11, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yfjPVz

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 11, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Feb 11, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.39%. Comparing base (d304977) to head (40d8722).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6182      +/-   ##
===========================================
- Coverage    81.39%   81.39%   -0.01%     
===========================================
  Files         2570     2570              
  Lines        69759    69759              
  Branches      8969     8968       -1     
===========================================
- Hits         56780    56779       -1     
- Misses        9644     9647       +3     
+ Partials      3335     3333       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 5cb5f5f into develop Feb 11, 2026
40 of 41 checks passed
@bmarty bmarty deleted the feature/bma/fixAppNavigationState branch February 11, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ganfra ganfra ganfra approved these changes

Assignees

No one assigned

Labels

A-Multi Account PR-Bugfix For bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmarty @ganfra